Thunderbolt 3 Hotplug #24
Comments
|
Thunderbolt SSDT does not work with OC. (Only with clover) On OC is causes an immediate freeze once you plug in the device (even if you boot with the device plugged in) Here is the debug 100 from it (don't see any useful info, just in case) : |
|
I realized that Thunderbolt 3 controller firmware version could also affect the functionality. @velaar I suggest you may try updating the thunderbolt 3 controller firmware on Windows. |
|
@Colton-Ko 's TB3 hotpatch is working for me under OpenCore. Does it work for you after updating the firmware under windows? |
|
@tylernguyen Did you test it with an eGPU? |
|
I haven't tried with an eGPU, but TB3 hotplugging seems to be working for me. |
|
@Porco-Rosso @tylernguyen I even flashed a "Mac Edition" firmware onto my RX590 but the crash was the same. The crash happens after the GPU is detected and the respective kext is loaded.
With TB3 v1 I was able to get a bit more verbose crash. I'll keep it here for reference: |
I tested my TB3 hotplug with the CalDigit Plus Dock and it worked. Unfortunately, I do not have an eGPU enclosure nor the proper graphics card to test that. |
|
TB3 hotplugging seems to have stopped working for me. This may be tied to the fact that I enabled Filevault, but cannot confirm that is the root cause. The Thunderbolt 3 section of the system profiler is blank even with the device working
|
|
@Porco-Rosso |
|
Thanks @velaar, that does seem to fix it. As I understand, this will increase power consumption however, correct? |
|
@Porco-Rosso |
|
Can someone confirm if the power-assist mode works with Ethernet port on thunderbolt hub standard one that comes with the laptop, tried connecting before and reconnecting after and tried both ports with no luck. HDM and usb ports work ok on the hub. |
|
@noclee I'm not sure what is the question. Maybe I'm missing something but I did not have any thunderbolt hubs coming with the laptop nor heard of the power-assist mode. |
|
@velaar Sorry let me try this way, query is on Ethernet port not working when thunderbolt BIOS power-assist is enabled. Anyone have this working |
|
Hi guys, If interested, here you have my setup:
Let me know if it works. EDIT: thanks |
|
@lubixxx96 Have you tested it with a thunderbolt device? |
|
no, I don't have a thunderbolt device. But I dont see thunderbolt in ioreg so I suppose it wont work. |
|
@velaar @Colton-Ko @Porco-Rosso @noclee Can you guys please try my new EFI folder? I added a new TB3 hotplug patch that is functioning much smoother than before. For my machine at least, TB3 hotplug now works with both Thunderbolt 3 ports. Fyi, if TB3 hotplug isn't working for you after updating the newest EFI folder, please try editing the SSDT-Z390-TB3HP.aml file with your appropriate TB3 controller path. After one or two of you guys can verify that it is working, I will mark it as working on the repo. |
|
Quick update, after some extended testing, it seems that I arrived at the same problem before. Hotplugging on the ethernet-TB3 port works flawlessly. Though hotplugging on the TB3 power port only works if the machine was booted with the TB3 device attached. It seems that this is as far as we can get without flashing the actual chip on the Thinkpad to use Apple's Thunderbolt firmware. If someone is willing to investigate, try, and document this, please check https://osy.gitbook.io/hac-mini-guide/details/thunderbolt-3-fix-part-3 |
|
I still get higher power consumption and crash on AMDFramebuffer.kext on hotplug/coldplug of the GPU without Thunderbolt Bios Assist. So no luck for me here. |
|
@tylernguyen your newest set of commits, as of 2f5361d have triggered some problems.
I'd like to stay as closely in-sync with your EFI, so hoping we can resolve some of these. |
|
@Porco-Rosso I cannot replicate these issues. Please reach out to me via Signal at (202)-644-9951. Hopefully, we can get them debugged. |
|
Thanks for the help @tylernguyen 👍 For others reading this:
|
|
@Porco-Rosso |
|
@velaar I just acquired an external GPU (Core X) and an AMD card. Did you ever manage to get it to work on MacOS, with any configuration (hotplug, non-hotplug, TB-BIOS assist, additional kexts etc..)? @tylernguyen thanks for the patch. Automatic switching appears to be working. As I understand this is done in the OS and not EFI? |
|
I wanted to add that I updated to the latest, tried this, and it worked. It shows a different menu bar icon to what I'd expect on a macbook but I got instant and smooth display output over an RX 570 eGPU.
Great work! Thank you! |
nope.. in the past I've seen this (which is a picture I found on the Internet) It is worth noting that the USB ports on the eGPU don't work but I'll try updating it to the latest commit on the repo as I see there are more. It presents 100% properly in system report: |
|
Love to hear more feedback / reports. Problem is that there are plenty of configurations and edgecases which I can't see or test because of missing hw... |
100%. Can't be expected to test everything, and what we now have is outstanding. 👍 🥇 |
|
@parndt As you seem to have an original Macbook and the X1 - could you post an IOReg-dump of both with the eGPU-attached? (done with https://github.com/vulgo/IORegistryExplorer) If I got both, I may be able to replicate a more native-handling on the X1 |
unfortunately I don't have the macbook with TB3 with me at the moment 😦 I can however get access to it, so I'll see if I can get this for you at some point. 😄 would love to help. |
|
one data point - powering off the card by unplugging it, or by clicking the menu bar option "power off card" seems to completely disable the built in trackpad until rebooted. |
Wtf? :) You are on the latest version of this repo? Could you post an ioreg-dump of the state when that happened? |
pretty weird huh! Yes, this was after updating to the latest. I'll get this for you as soon as I can. |
|
Is this accurate:
If I set both to disabled as per the below because I do want hotplug, I get no eGPU at all, which makes sense but it is what the README says.. 😕 |
|
@tylernguyen see above ;) |
What Thunderbolt BIOS settings do you have eGPU working under? |
|
by |
|
with RTD3 (= Runtime D3, aka runtime-disable) ;) |
There seems to be some confusion. The lower settings is Pre Boot support for Thunderbolt. Note the sub menu that it's under. |
I have a Macbook on hand so I will try to provide this 👍 However I am also getting confused on the BIOS settings now... |
yeah! :)
+1 - but however, "preboot" should be disabled. We want the BIOS and TB-firmware to stay out of TB as far as possible and handle connection-control in ACPI + OSX. |
|
Hi @benbender here are the IOReg dumps. I hope I did them correctly. You will find 4 files, real Macbook with and without eGPU and X1 with and without eGPU. Here is how the eGPU works (hot-plug working!) System Profile and menubar
Here is the BIOS config, in line with what I could understand - we really should clear this up. BIOS
I will note, that under this current config the ethernet on my usb-c dock does not work (HDMI does...) and this is quite important to me, so any tips would be appreciated. I suspect something in the BIOS? The link to IORegistryExplorer no longer works, but I managed to grab the latest release before it went down. Let me know if anyone needs it. |
|
@Porco-Rosso Thanks! Thats a huge help, will have a closer look as soon as possible! For your questions:
|
|
I've updated documentation to make things clearer about the new TB3 hotplug patches:
As @benbender stated and newly noted in the docs, the new patches do not require a modded BIOS. The only changes need are adjustable within the stock BIOS and are detailed in the docs. |
|
Ok, I haven't changed any of the settings in the more advanced settings, apart from the same ones you mentioned @benbender. ( The ones in the repo ) The USB dock is a rebranded version of this one: https://www.amazon.com/dp/B0841T9KC9 . Don't want to detract too much, so if I can't figure it out myself, I will open another issue. |
I found this setting under the Intel advanced menu -> Thunderbolt(TM) Configuration -> "Thunderbolt(TM) OS select" right down the bottom |
|
I'm quite sure that's what @benbender means. @parndt EDIT: Remember that the Advance Menu can be quite buggy so multiple resets and checks maybe required to make sure things are properly reverted to stock. |
Absolutely yes.
Please test the latest fixes in this repo and report back. |
|
The latest changes seem to have worked, thanks @benbender! |
This comment has been minimized.
This comment has been minimized.
EDIT 11/17/2020:
Thunderbolt 3 Hotplug is works on both ports and is natively detected within System Report by macOS. USB 3.1 Gen2 Hotplug is still work in progress.
Reminder that this should work without a modded BIOS. The only necessary BIOS settings are detailed in https://github.com/tylernguyen/x1c6-hackintosh/blob/master/docs/1_README-HARDWAREandBIOS.md
If you have previous messed with TB3 related settings within the custom firmware, please BIOS + NVRAM reset to revert things back to default. Remember that the Advance Menu can be quite buggy so multiple resets and checks maybe required to make sure things are properly reverted to stock.
Thunderbolt 3 can involve many edges cases and different hardware that I cannot test or do not have the hardware to so please contribute if you experience/fix a problem.
Lastly, all this progress would not have been possible without the hard work of @benbender so thank you!
The text was updated successfully, but these errors were encountered: